Load Google Fonts non-blocking on the demo page#37
Merged
Conversation
fbuys
approved these changes
Jul 16, 2026
fbuys
left a comment
fbuys
left a comment
Member
There was a problem hiding this comment.
Looks good, matches implementation in ombulabs styleguide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**IMPORTANT: Please read the README before submitting pull requests for this project. Additionally, if your PR closes any open GitHub issues, make sure you include Closes #XXXX in your comment or use the option on the PR's sidebar to add related issues to auto-close the issue that your PR fixes. **
Description:
Follow-up to the font work merged in #36, mirroring the non-blocking part of ombulabs/styleguide#70. The Google Fonts request was still render-blocking.
media="print"+onload="this.media='all'"swap) with a<noscript>fallback inindex.html$fa-font-displaypart of OMBU-793: Set FontAwesome font-display to swap and load fonts non-blocking ombulabs/styleguide#70 doesn't apply hereQA
index.html, DevTools => Network => filter by fonts: the css2 request loads non-blocking and doesn't hold up first paint.<noscript>fallback still loads the fonts.I will abide by the code of conduct.